Solved Please correct my tweak.xm

[Fadexz 5.7k iPhone X 14.3]

Could someone please correct my tweak.xm?

 

@Ted2 You beast, you usually are good at this

 

Tweak.xm

#include <substrate.h>

%hook XBXAchievement

-(BOOL)isSecret {
return FALSE;
}
%end

%hook XBXAchievement

-(void)setIsSecret:(BOOL)arg1 {
arg1 = FALSE;
return %orig;
}
%end

%hook XBXSLSAchievementTileLocator

+(id)getTileSubPath:(id)arg1 dimensions:(unsigned short)arg2 achieved:(BOOL)arg3 secret:(BOOL) {
arg3 = FALSE;
arg4 = FALSE;
return %orig;
}
%end

%hook XBXSLSAchievementTileLocator

+(id)getTileLocationForImageId:(unsigned int)arg1 fromTitleId:(unsigned int)arg2 achieved:(BOOL)arg3 secret:(BOOL) {
arg3 = FALSE;
arg4 = FALSE;
return %orig;
}
%end

%hook XBXSLS360TitleAchievementsResponse

-(id)getAchievementImageUrl:(unsigned int)arg1 titleId:(unsigned int)arg2 achieved:(BOOL)arg3 secret:(BOOL) {
arg3 = FALSE;
arg4 = FALSE;
return %orig;
}
%end

 

Error

Tweak.xm:20:176: error: expected class member or base class name
  ...SEL _cmd, id arg1, unsigned short arg2, BOOL arg3):(BOOL) {
                                                        ^
Tweak.xm:20:176: error: expected '{' or ','
Tweak.xm:20:175: error: only constructors take base initializers
  ...SEL _cmd, id arg1, unsigned short arg2, BOOL arg3):(BOOL) {
                                                       ^
Tweak.xm:22:1: error: use of undeclared identifier 'arg4'
arg4 = FALSE;
^
Tweak.xm:29:196: error: expected class member or base class name
  ...unsigned int arg1, unsigned int arg2, BOOL arg3):(BOOL) {
                                                      ^
Tweak.xm:29:196: error: expected '{' or ','
Tweak.xm:29:195: error: only constructors take base initializers
  ...unsigned int arg1, unsigned int arg2, BOOL arg3):(BOOL) {
                                                     ^
Tweak.xm:31:1: error: use of undeclared identifier 'arg4'
arg4 = FALSE;
^
Tweak.xm:38:220: error: expected class member or base class name
  ...unsigned int arg1, unsigned int arg2, BOOL arg3):(BOOL) {
                                                      ^
Tweak.xm:38:220: error: expected '{' or ','
Tweak.xm:38:219: error: only constructors take base initializers
  ...unsigned int arg1, unsigned int arg2, BOOL arg3):(BOOL) {
                                                     ^
Tweak.xm:40:1: error: use of undeclared identifier 'arg4'
arg4 = FALSE;
^
12 errors generated.
make[2]: *** [obj/Tweak.xm.f28eec72.o] Error 1
make[1]: *** [internal-library-all_] Error 2
make: *** [XboxSmartGlassShowHiddenAchievements.all.tweak.variables] Error 2

 

Any help is appreciated.  

Updated November 1, 2017 by Fadexz
Added a line XD Changed to solved.

[Caroline_ 3.1k iPhone 14 Pro Max 16]

8 minutes ago, Fadexz said:

Could someone please correct my tweak.xm?

 

Tweak.xm

#include <substrate.h>

%hook XBXAchievement

-(BOOL)isSecret {
return FALSE;
}
%end

%hook XBXAchievement

-(void)setIsSecret:(BOOL)arg1 {
arg1 = FALSE;
return %orig;
}
%end

%hook XBXSLSAchievementTileLocator

+(id)getTileSubPath:(id)arg1 dimensions:(unsigned short)arg2 achieved:(BOOL)arg3 secret:(BOOL) {
arg3 = FALSE;
arg4 = FALSE;
return %orig;
}
%end

%hook XBXSLSAchievementTileLocator

+(id)getTileLocationForImageId:(unsigned int)arg1 fromTitleId:(unsigned int)arg2 achieved:(BOOL)arg3 secret:(BOOL) {
arg3 = FALSE;
arg4 = FALSE;
return %orig;
}
%end

%hook XBXSLS360TitleAchievementsResponse

-(id)getAchievementImageUrl:(unsigned int)arg1 titleId:(unsigned int)arg2 achieved:(BOOL)arg3 secret:(BOOL) {
arg3 = FALSE;
arg4 = FALSE;
return %orig;
}
%end

 

Error

Tweak.xm:20:176: error: expected class member or base class name
  ...SEL _cmd, id arg1, unsigned short arg2, BOOL arg3):(BOOL) {
                                                        ^
Tweak.xm:20:176: error: expected '{' or ','
Tweak.xm:20:175: error: only constructors take base initializers
  ...SEL _cmd, id arg1, unsigned short arg2, BOOL arg3):(BOOL) {
                                                       ^
Tweak.xm:22:1: error: use of undeclared identifier 'arg4'
arg4 = FALSE;
^
Tweak.xm:29:196: error: expected class member or base class name
  ...unsigned int arg1, unsigned int arg2, BOOL arg3):(BOOL) {
                                                      ^
Tweak.xm:29:196: error: expected '{' or ','
Tweak.xm:29:195: error: only constructors take base initializers
  ...unsigned int arg1, unsigned int arg2, BOOL arg3):(BOOL) {
                                                     ^
Tweak.xm:31:1: error: use of undeclared identifier 'arg4'
arg4 = FALSE;
^
Tweak.xm:38:220: error: expected class member or base class name
  ...unsigned int arg1, unsigned int arg2, BOOL arg3):(BOOL) {
                                                      ^
Tweak.xm:38:220: error: expected '{' or ','
Tweak.xm:38:219: error: only constructors take base initializers
  ...unsigned int arg1, unsigned int arg2, BOOL arg3):(BOOL) {
                                                     ^
Tweak.xm:40:1: error: use of undeclared identifier 'arg4'
arg4 = FALSE;
^
12 errors generated.
make[2]: *** [obj/Tweak.xm.f28eec72.o] Error 1
make[1]: *** [internal-library-all_] Error 2
make: *** [XboxSmartGlassShowHiddenAchievements.all.tweak.variables] Error 2

 

Any help is appreciated.  

I see the problem  

Simple fix

[Fadexz 5.7k iPhone X 14.3]

8 minutes ago, PrincessJayJay said:

I see the problem  

Simple fix

You probably shouldn't have quoted my message lol.

 

If you see the problem please correct it for me then. 

[Ted2 39.2k iPhone 13 Pro 16.0 Donor]

#include <substrate.h>

%hook XBXAchievement

-(BOOL)isSecret {
return FALSE;
}
%end

%hook XBXAchievement

-(void)setIsSecret:(BOOL)arg1 {
arg1 = FALSE;
return %orig;
}
%end

%hook XBXSLSAchievementTileLocator

+(id)getTileSubPath:(id)arg1 dimensions:(unsigned short)arg2 achieved:(BOOL)arg3 secret:(BOOL)arg4 { //Added arg4 after BOOL
arg3 = FALSE;
arg4 = FALSE;
return %orig;
}
%end

%hook XBXSLSAchievementTileLocator

+(id)getTileLocationForImageId:(unsigned int)arg1 fromTitleId:(unsigned int)arg2 achieved:(BOOL)arg3 secret:(BOOL)arg4 { //Added arg4 after BOOL
arg3 = FALSE;
arg4 = FALSE;
return %orig;
}
%end

%hook XBXSLS360TitleAchievementsResponse

-(id)getAchievementImageUrl:(unsigned int)arg1 titleId:(unsigned int)arg2 achieved:(BOOL)arg3 secret:(BOOL)arg4 { //Added arg4 after BOOL
arg3 = FALSE;
arg4 = FALSE;
return %orig;
}
%end

 

You were close, you forgot to add arg4 in the function name but did return it

[Fadexz 5.7k iPhone X 14.3]

Oh wow.. it was that simple.

 

Thanks @Ted2 you always seem to be the one to help.  

[Ted2 39.2k iPhone 13 Pro 16.0 Donor]

19 minutes ago, Fadexz said:

Oh wow.. it was that simple.

 

Thanks @Ted2 you always seem to be the one to help.  

Mark solved

[Fadexz 5.7k iPhone X 14.3]

43 minutes ago, Ted2 said:

Mark solved

That would be a good idea.